[RTPproxy Devel] [RTPproxy Users] patch - per-channel timeouts, notification on timeout

[Maxim Sobolev]

Daniel Pocock wrote:
> 
> Maxim Sobolev wrote:
>> Daniel Pocock wrote:
>>   
>>>> 1. I would like the make it possible to enable/disable "disconnect 
>>>> notification" feature on the per-call basis. Basically, the idea is that 
>>>> the client code will pass the address that it wants rtpproxy to send the 
>>>> disconnect notification to with the "create session" request. This would 
>>>> allow several "disconnect-aware" clients to share one proxy.
>>>>
>>>>   
>>>>       
>>> The socket information is now encapsulated in a struct, and each 
>>> rtpp_session keeps a pointer to the struct.
>>>
>>> Currently, all pointers are initialised to point to a single struct in 
>>> the config struct, the command for controlling this on a per-call basis 
>>> can be added later.
>>>     
>> The problem with adding this functionality as is now and extending it 
>> later is that rtpproxy will have to support both ways - notify all, and 
>> notify on per-call basis. I don't think that we really need this. The 
>> change to allow notifications to be enabled on per-calls basis is pretty 
>> trivial, so that doing it now we will save us from either breaking 
>> protocol later or carrying compatibility code. I think the best way to 
>> achieve that is to add flag to the U command to enable notification to 
>> that single socket (if any specified) now, while extend protocol later 
>> to allow for the optional socket name parameter to be passed somehow 
>> along with that.
>>
>>   
> 
> Ok, so this is the new behaviour:
> 
> - u/U takes another argument, the pathname of the socket
> - if the pathname is known by rtpproxy, the socket is configured for the 
> session
> - if the pathname is not known, an error is logged and the update is 
> processed anyway

Sounds good.

> - if the pathname is missing, any existing socket configuration for that 
> session will be removed

I don't understand the last one. Can you please explain in more details 
what do you mean by that?

-Maxim