From sobomax at sippysoft.com Fri May 29 16:48:04 2009 From: sobomax at sippysoft.com (Maxim Sobolev) Date: Sat, 30 May 2009 01:48:04 +0200 (CEST) Subject: [RTPproxy Devel] CVS:commitlog: rtpproxy main.c manpage.xml rtpp_defines.h rtpp_log.c rtpp_log.h Message-ID: <20090529234804.F17F31811FD@mail.berlios.de> sobomax 2009/05/30 01:48:04 CEST SER CVS Repository Modified files: . main.c manpage.xml rtpp_defines.h rtpp_log.c rtpp_log.h Log: Add ability to set syslog facility (by adding it after : to the argument of the -d option), i.e. -d WARN:LOG_LOCAL5. Suggested by: Inaki Baz Castillo Revision Changes Path 1.89 +11 -3 rtpproxy/main.c http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/rtpproxy/main.c.diff?r1=1.88&r2=1.89 1.10 +8 -4 rtpproxy/manpage.xml http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/rtpproxy/manpage.xml.diff?r1=1.9&r2=1.10 1.25 +2 -1 rtpproxy/rtpp_defines.h http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/rtpproxy/rtpp_defines.h.diff?r1=1.24&r2=1.25 1.2 +47 -1 rtpproxy/rtpp_log.c http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/rtpproxy/rtpp_log.c.diff?r1=1.1&r2=1.2 1.7 +2 -1 rtpproxy/rtpp_log.h http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/rtpproxy/rtpp_log.h.diff?r1=1.6&r2=1.7 From sobomax at sippysoft.com Fri May 29 16:48:19 2009 From: sobomax at sippysoft.com (Maxim Sobolev) Date: Sat, 30 May 2009 01:48:19 +0200 (CEST) Subject: [RTPproxy Devel] CVS:commitlog: rtpproxy rtpproxy.8 Message-ID: <20090529234819.8042D13632@mail.berlios.de> sobomax 2009/05/30 01:48:19 CEST SER CVS Repository Modified files: . rtpproxy.8 Log: Regen. Revision Changes Path 1.9 +8 -4 rtpproxy/rtpproxy.8 http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/rtpproxy/rtpproxy.8.diff?r1=1.8&r2=1.9 From sobomax at sippysoft.com Fri May 29 17:15:28 2009 From: sobomax at sippysoft.com (Maxim Sobolev) Date: Sat, 30 May 2009 02:15:28 +0200 (CEST) Subject: [RTPproxy Devel] CVS:commitlog: rtpproxy rtpp_log.c Message-ID: <20090530001528.0EFC5E70F@mail.berlios.de> sobomax 2009/05/30 02:15:28 CEST SER CVS Repository Modified files: . rtpp_log.c Log: Make it possible to specify syslog facility without the LOG_ prefix, i.e. -d warn:local5. Revision Changes Path 1.3 +3 -2 rtpproxy/rtpp_log.c http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/rtpproxy/rtpp_log.c.diff?r1=1.2&r2=1.3 From sobomax at sippysoft.com Fri May 29 17:50:13 2009 From: sobomax at sippysoft.com (Maxim Sobolev) Date: Sat, 30 May 2009 02:50:13 +0200 (CEST) Subject: [RTPproxy Devel] CVS:commitlog: rtpproxy main.c manpage.xml rtpp_command.c Message-ID: <20090530005013.3BC85181499@mail.berlios.de> sobomax 2009/05/30 02:50:13 CEST SER CVS Repository Modified files: . main.c manpage.xml rtpp_command.c Log: Allow IP ToS (type of service) setting be disabled by specifying `-t -1' on command line. Suggested by: Inaki Baz Castillo While I am here, validabe used-supplied ToS value and throw error if it's too large. Revision Changes Path 1.90 +3 -1 rtpproxy/main.c http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/rtpproxy/main.c.diff?r1=1.89&r2=1.90 1.11 +4 -2 rtpproxy/manpage.xml http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/rtpproxy/manpage.xml.diff?r1=1.10&r2=1.11 1.27 +2 -2 rtpproxy/rtpp_command.c http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/rtpproxy/rtpp_command.c.diff?r1=1.26&r2=1.27 From sobomax at sippysoft.com Fri May 29 17:50:59 2009 From: sobomax at sippysoft.com (Maxim Sobolev) Date: Sat, 30 May 2009 02:50:59 +0200 (CEST) Subject: [RTPproxy Devel] CVS:commitlog: rtpproxy rtpproxy.8 Message-ID: <20090530005059.0DF1B21B16@mail.berlios.de> sobomax 2009/05/30 02:50:59 CEST SER CVS Repository Modified files: . rtpproxy.8 Log: Re-gen. Revision Changes Path 1.10 +2 -2 rtpproxy/rtpproxy.8 http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/rtpproxy/rtpproxy.8.diff?r1=1.9&r2=1.10 From ibc at aliax.net Sun May 31 11:07:01 2009 From: ibc at aliax.net (=?utf-8?q?I=C3=B1aki_Baz_Castillo?=) Date: Sun, 31 May 2009 20:07:01 +0200 Subject: [RTPproxy Devel] [patch] Debian init script LSB compliant Message-ID: <200905312007.01532.ibc@aliax.net> Hi, I attach a ptch for rtpproxy Debian init script which allows it being LSB compliant. Basically I add "--oknodo" option to all calls to "start-stop-daemon" which, by default, is not LSB compliant. Being LSB compliant is really useful when we want to manage a service (like RtpProxy) using some failover system as HeartBeat, which relies on *exact* reply code of the init scripts. About LSB specification [1] for init scripts which I refer to: --------------------- "For all other init-script actions, the init script shall return an exit status of zero if the action was successful. Otherwise, the exit status shall be non-zero, as defined below. In addition to straightforward success, the following situations are also to be considered successful: - Restarting a service (instead of reloading it) with the force-reload argument - Running start on a service already running - Running stop on a service already stopped or not running - Running restart on a service already stopped or not running - Running try-restart on a service already stopped or not running" So if I start a service that is already running I should receive 0, but "start-stop-daemon" returns 1 (error). The option "--oknodo" changes the behaviour to the LSB recomendations but many services in Debian don't use this option and return 1 in the case I've quotted. This is very problematic for me when I try to use a Debian service init script with HeartBeat that expects to receive a 0. ----------------------- So adding "--oknodo" to the init script, "/etc/init.d/rtpproxy start" returns 0 (no error) even if RtpProxy is already running, and "/etc/init.d/rtpproxy stop" returns 0 (no error) even if RtpProxy is not running (as LSB mandates). Note however that in Debian Lenny the default behaviour of "start-stop-daemon" has changed to implement this LSB compliant behaviour by default. This is the bug report I opened in Debian for this issue: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=426877 [1] LSB specifications about init script actions: http://www.linux-foundation.org/spec/refspecs/LSB_3.0.0/LSB-Core-generic/LSB- Core-generic/iniscrptact.html -- I?aki Baz Castillo -------------- next part -------------- A non-text attachment was scrubbed... Name: rtpproxy.init.patch Type: text/x-patch Size: 1017 bytes Desc: not available Url : http://lists.rtpproxy.org/pipermail/devel/attachments/20090531/1befad33/attachment.bin From sobomax at sippysoft.com Sun May 31 23:53:00 2009 From: sobomax at sippysoft.com (Maxim Sobolev) Date: Mon, 1 Jun 2009 08:53:00 +0200 (CEST) Subject: [RTPproxy Devel] CVS:commitlog: rtpproxy rtpp_log.c Message-ID: <20090601065300.D0A13181849@mail.berlios.de> sobomax 2009/06/01 08:53:00 CEST SER CVS Repository Modified files: . rtpp_log.c Log: Actually pass facility into openlog(3) call. Revision Changes Path 1.4 +2 -2 rtpproxy/rtpp_log.c http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/rtpproxy/rtpp_log.c.diff?r1=1.3&r2=1.4