[RTPproxy Devel] [sr-dev] CVS:commitlog: rtpproxy main.c rtpp_defines.h rtpp_log.c rtpp_syslog_async.c rtpp_syslog_async.h

[Maxim Sobolev]

Peter Lemenkov wrote:
> Hello, All!
> 
> 2009/10/6 Maxim Sobolev <sobomax at sippysoft.com>:
> 
>>  Fix serious issue wich can happen with default loging method (syslog)
>>  at the default log level (debug). I'm unsure if it affects all Linux systems
>>  or not, but at least on one CentOS release 5.3 the vsyslog(3) call takes
>>  ridiculously large amount of time to complete. Few of such calls easily
>>  take 1-2 seconds. Since the RTPproxy is still single-threaded, this means
>>  that traffic halts for that duration, which is obviously bad.
> 
> Default syslog facility (sysklogd) in RHEL/CentOS is broken, indeed.
> We just switched to syslog-ng (from EPEL).
> 
> Actually, I don't think that it should be fixed that way - I strongly
> advise everyone to change syslog-daemon instead.

I don't necessarily agree to the latter conclusion. syslog(3) is by 
definition a blocking API, so that we need unblocking version for the 
time-sensitive code and this change adds such version. It will be useful 
with any syslog implementation, even if the better version takes only 
10ms instead of 200ms to complete.

This change represents part of the larger effort to make RTPproxy 
multi-threaded to better utilize current multi-core CPUs and operating 
systems. There are more changes coming in the nearest future.

Regards,
-- 
Maksym Sobolyev
Sippy Software, Inc.
Internet Telephony (VoIP) Experts
T/F: +1-646-651-1110
Web: http://www.sippysoft.com
MSN: sales at sippysoft.com
Skype: SippySoft